Create hrdkorea.json #553
Closed
Create hrdkorea.json #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Mar 26, 2024
methods/hrdkorea.json
Outdated
| // These fields are optional | ||
| "contactName": "HRDKorea", | ||
| "contactEmail": "", | ||
| "contactWebsite": "mq.q-net.or.kr", |
|
New DID Method review volunteers, please review this DID Method. /cc @apuchitnis @stenreijers @gatemezing @esaung @michallis @richardwinputra @adam-burns @Steffytan @MizukiSonoko @rajivrajani @genaris @harleyjackthomas @ajile-in @KDean-Dolphin |
|
HRDKOR
requested review from
apuchitnis,
stenreijers,
gatemezing,
adam-burns,
Steffytan,
MizukiSonoko,
rajivrajani,
genaris,
ajile-in and
KDean-Dolphin
as code owners
msporny
requested changes
Jul 20, 2024
There was a problem hiding this comment.
The JSON markup is invalid; JSON does not support comments.
The Privacy and Security Considerations section does not meet minimum requirements (write at least a few paragraphs). Please see this specification for a good example of those sections: https://did-dht.com/#security-and-privacy-considerations
|
Closing, duplicate of #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions for Pull Requests
Please read these instructions thoroughly in order to ensure that your pull request is processed in a timely manner. This document contains detailed instructions for registering a DID Method. If your pull request concerns some other change to the repository, you may delete all of the text in this text box and write up a more relevant description.
There is a DID Method Registration form below that MUST be included in a DID Method Registration Request. The form includes check boxes that you are expected to fill out when you submit your request.
Once you submit your request, your pull request will be reviewed by the registry editors. Changes regarding the required criteria may be requested. If there are no objections or changes requested, your DID method will be registered after a minimum of 7 days and a maximum of 30 days.
DID Method Registration Process
In order to register a new DID method, you must add a JSON file to the ./methods directory.
Here is an example registration entry:
Your Pull Request will be automatically validated, please ensure that all of the automated tests pass (no errors reported) or your submission will not be reviewed. Common reasons for failed validation includes invalidly formatted JSON files and missing mandatory fields.
----- DID METHOD REGISTRATION FORM: DELETE EVERYTHING ABOVE THIS LINE ------
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmailaddress [OPTIONAL].verifiableDataRegistryentry [OPTIONAL].